Add 'WithDictIndex' expiry API and update RANDOMKEY command #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1155 +/- ##
============================================
+ Coverage 70.66% 70.68% +0.02%
============================================
Files 114 114
Lines 61716 61799 +83
============================================
+ Hits 43611 43683 +72
- Misses 18105 18116 +11
|
madolson
reviewed
Oct 11, 2024
madolson
reviewed
Oct 12, 2024
madolson
reviewed
Oct 12, 2024
|
@nadav-levanoni Please fix the DCO issue, as described in the Details link next to the failed DCO CI job (or here). What is DCO and why we need it is described in CONTRIBUTING.md. |
Signed-off-by: Nadav Levanoni <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Nadav Levanoni <[email protected]>
nadav-levanoni
force-pushed
the
issue-1145
branch
from
db08809 to
0e4e2e1
Compare
Signed-off-by: Nadav Levanoni <[email protected]>
Signed-off-by: Nadav Levanoni <[email protected]>
Signed-off-by: Nadav Levanoni <[email protected]>
Signed-off-by: Nadav Levanoni <[email protected]>
nadav-levanoni
changed the title
madolson
changed the title
madolson
reviewed
Oct 17, 2024
Signed-off-by: Madelyn Olson <[email protected]>
madolson
added
the
release-notes
eifrah-aws
pushed a commit
to eifrah-aws/valkey
that referenced
this pull request
Oct 20, 2024
…o#1155) valkey-io#1145 First part of a two-step effort to add `WithSlot` API for expiry. This PR is to fix a crash that occurs when a RANDOMKEY uses a different slot than the cached slot of a client during a multi-exec. The next part will be to utilize the new API as an optimization to prevent duplicate work when calculating the slot for a key. --------- Signed-off-by: Nadav Levanoni <[email protected]> Signed-off-by: Madelyn Olson <[email protected]> Co-authored-by: Nadav Levanoni <[email protected]> Co-authored-by: Madelyn Olson <[email protected]>
madolson
added a commit
to madolson/valkey
that referenced
this pull request
Jan 6, 2025
…o#1155) valkey-io#1145 First part of a two-step effort to add `WithSlot` API for expiry. This PR is to fix a crash that occurs when a RANDOMKEY uses a different slot than the cached slot of a client during a multi-exec. The next part will be to utilize the new API as an optimization to prevent duplicate work when calculating the slot for a key. --------- Signed-off-by: Nadav Levanoni <[email protected]> Signed-off-by: Madelyn Olson <[email protected]> Co-authored-by: Nadav Levanoni <[email protected]> Co-authored-by: Madelyn Olson <[email protected]>
madolson
added a commit
to madolson/valkey
that referenced
this pull request
Jan 7, 2025
…o#1155) valkey-io#1145 First part of a two-step effort to add `WithSlot` API for expiry. This PR is to fix a crash that occurs when a RANDOMKEY uses a different slot than the cached slot of a client during a multi-exec. The next part will be to utilize the new API as an optimization to prevent duplicate work when calculating the slot for a key. --------- Signed-off-by: Nadav Levanoni <[email protected]> Signed-off-by: Madelyn Olson <[email protected]> Co-authored-by: Nadav Levanoni <[email protected]> Co-authored-by: Madelyn Olson <[email protected]>
madolson
added a commit
that referenced
this pull request
Jan 7, 2025
#1145 First part of a two-step effort to add `WithSlot` API for expiry. This PR is to fix a crash that occurs when a RANDOMKEY uses a different slot than the cached slot of a client during a multi-exec. The next part will be to utilize the new API as an optimization to prevent duplicate work when calculating the slot for a key. --------- Signed-off-by: Nadav Levanoni <[email protected]> Signed-off-by: Madelyn Olson <[email protected]> Co-authored-by: Nadav Levanoni <[email protected]> Co-authored-by: Madelyn Olson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1145
First part of a two-step effort to add
WithSlotAPI for expiry. This PR is to fix a crash that occurs when a RANDOMKEY uses a different slot than the cached slot of a client during a multi-exec.The next part will be to utilize the new API as an optimization to prevent duplicate work when calculating the slot for a key.