-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move prepareClientToWrite out of loop for HGETALL command #1119
Merged
+59
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to valkey-io#860 but this is for HGETALL families (HGETALL/HKEYS/HVALS). This patch moves `prepareClientToWrite` out of the loop to reduce the function overhead. | test | unstable(150c197) rpc | this patch (rpc) | improvements | | ------------- | -------------------------- | ---------------- | ------------ | | HGETALL h1 | 85084.66 | 86926.29 | 2.16446772 | | HGETALL h10 | 78400.62 | 76893.5 | -1.922331737 | | HGETALL h25 | 64487.01 | 58802.77 | -8.814550403 | | HGETALL h50 | 47587.32 | 49360.78 | 3.726749058 | | HGETALL h100 | 33028.37 | 34454.25 | 4.317137055 | | HGETALL h300 | 14628.22 | 15540.98 | 6.239720212 | | HGETALL h500 | 9593.52 | 10395.44 | 8.358975642 | Signed-off-by: Masahiro Ide <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1119 +/- ##
============================================
- Coverage 70.60% 70.50% -0.11%
============================================
Files 114 114
Lines 61717 61734 +17
============================================
- Hits 43578 43526 -52
- Misses 18139 18208 +69
|
rjd15372
reviewed
Oct 4, 2024
Signed-off-by: Masahiro Ide <[email protected]>
Signed-off-by: Masahiro Ide <[email protected]>
madolson
reviewed
Oct 7, 2024
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: Masahiro Ide <[email protected]>
…check by compiler Signed-off-by: Masahiro Ide <[email protected]>
Signed-off-by: Masahiro Ide <[email protected]>
Signed-off-by: Masahiro Ide <[email protected]>
madolson
added
release-notes
This issue should get a line item in the release notes
performance
labels
Oct 11, 2024
madolson
approved these changes
Oct 12, 2024
eifrah-aws
pushed a commit
to eifrah-aws/valkey
that referenced
this pull request
Oct 20, 2024
…1119) Similar to valkey-io#860 but this is for HGETALL families (HGETALL/HKEYS/HVALS). This patch moves `prepareClientToWrite` out of the loop to reduce the function overhead. Signed-off-by: Masahiro Ide <[email protected]> Co-authored-by: Madelyn Olson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #860 but this is for HGETALL families (HGETALL/HKEYS/HVALS). This patch moves
prepareClientToWrite
out of the loop to reduce the function overhead.