Fix RDMA build dependence #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDMA module has dependence on '$(SERVER_NAME)' rather than the old style '$(REDIS_SERVER_NAME)'. Signed-off-by: zhenwei pi <[email protected]>
|
So this causes a problem when building with -j10. Let's include it in the next patch release. |
zuiderkwast
approved these changes
Sep 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1074 +/- ##
============================================
- Coverage 70.60% 70.59% -0.02%
============================================
Files 114 114
Lines 61695 61695
============================================
- Hits 43560 43551 -9
- Misses 18135 18144 +9 |
enjoy-binbin
added
the
release-notes
madolson
pushed a commit
to madolson/valkey
that referenced
this pull request
Sep 30, 2024
RDMA module has dependence on '$(SERVER_NAME)' rather than the old style '$(REDIS_SERVER_NAME)'. Signed-off-by: zhenwei pi <[email protected]>
naglera
pushed a commit
to naglera/placeholderkv
that referenced
this pull request
Oct 10, 2024
RDMA module has dependence on '$(SERVER_NAME)' rather than the old style '$(REDIS_SERVER_NAME)'. Signed-off-by: zhenwei pi <[email protected]> Signed-off-by: naglera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDMA module has dependence on '$(SERVER_NAME)' rather than the old style '$(REDIS_SERVER_NAME)'.