Edit Chinese MobilePhone Verifying regular. #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profnandaa
reviewed
Mar 17, 2018
| @@ -70,7 +70,7 @@ var phones = { | |||
| 'tr-TR': /^(\+?90|0)?5\d{9}$/, | |||
| 'uk-UA': /^(\+?38|8)?0\d{9}$/, | |||
| 'vi-VN': /^(\+?84|0)?((1(2([0-9])|6([2-9])|88|99))|(9((?!5)[0-9])))([0-9]{7})$/, | |||
| 'zh-CN': /^(\+?0?86\-?)?1[3456789]\d{9}$/, | |||
| 'zh-CN': /^((\+|00)86)?1([358][0-9]|4[579]|66|7[0135678]|9[89])[0-9]{8}$/, | |||
There was a problem hiding this comment.
Did you just change to a more specific validator here, more like a subset of the previous one?
There was a problem hiding this comment.
This rule is more stringent, thank you.
There was a problem hiding this comment.
Strict verification is not necessary. China's phone numbers are increasing very fast, and new numbers will be added every once in a while. The use of strict verification will be difficult to maintain.
|
This appears to be more strict than the existing version. Can you provide a source for the pattern? |
|
I'm going to merge this one, as it appears to fix one of the reported bugs: #866 |
|
You made a wise choice. Thank you! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I re - submitted one, you can merge it to master branch. Thank you very much!