fix(isURL): block credentials in protocol-relative URLs (+ regression tests) #2613
+39
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch hardens isURL for protocol-relative inputs by rejecting credentials in the authority
(e.g.
//user:[email protected]) whenallow_protocol_relative_urlsis true.https:example.com/http:example.comhttps://example.comandhttp://example.com/path?x=1#yNo API changes; minimal code change in the
//branch. All tests and lint pass locally.