-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isMobilePhone): add validation for ro-MD #2475
base: master
Are you sure you want to change the base?
feat(isMobilePhone): add validation for ro-MD #2475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the RegEx again based on https://www.itu.int/dms_pub/itu-t/oth/02/02/T020200008C0003PDFE.pdf which mentions that 760, 767 are also in use amongst other numbers. Other official sources that are more up to date are also valid of course
Hi, @WikiRik , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add tests for updated portion of regex too
Hi, @rubiin , |
This PR addresses issue #1931 and resolves merge conflicts from PR #2062.
The example phone numbers used are sourced from wikipedia
Checklist