Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isMobilePhone): add validation for ro-MD #2475

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mrpmohiburrahman
Copy link

@mrpmohiburrahman mrpmohiburrahman commented Oct 18, 2024

This PR addresses issue #1931 and resolves merge conflicts from PR #2062.

The example phone numbers used are sourced from wikipedia

Checklist

  • [x ] PR contains only changes related; no stray files, etc.
  • [ x] README updated (where applicable)
  • [ x] Tests written (where applicable)
  • [ x] References provided in PR (where applicable)

@rubiin rubiin requested a review from WikiRik November 12, 2024 16:27
rubiin
rubiin previously approved these changes Nov 12, 2024
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the RegEx again based on https://www.itu.int/dms_pub/itu-t/oth/02/02/T020200008C0003PDFE.pdf which mentions that 760, 767 are also in use amongst other numbers. Other official sources that are more up to date are also valid of course

@mrpmohiburrahman
Copy link
Author

Please check the RegEx again based on https://www.itu.int/dms_pub/itu-t/oth/02/02/T020200008C0003PDFE.pdf which mentions that 760, 767 are also in use amongst other numbers. Other official sources that are more up to date are also valid of course

Hi, @WikiRik ,
Added regex for 760, 767

rubiin

This comment was marked as duplicate.

Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tests for updated portion of regex too

@mrpmohiburrahman
Copy link
Author

add tests for updated portion of regex too

Hi, @rubiin ,
I've added tests for updated portion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants