Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isISO31661Numeric): Add validation for ISO 3166-1 numeric country codes #2399

Merged
merged 4 commits into from
May 10, 2024

Conversation

RobinvanderVliet
Copy link
Contributor

The ISO 3166-1 standard contains three sets of country codes: two-letter, three-letter, and three-digit. Currently, we have a validator for two-letter codes (isISO31661Alpha2) and three-letter codes (isISO31661Alpha3), but not for three-digit codes. This pull request addresses that.

References

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@rubiin rubiin added the ✅ LGTM label May 9, 2024
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@profnandaa profnandaa merged commit 79f5d18 into validatorjs:master May 10, 2024
10 checks passed
@RobinvanderVliet RobinvanderVliet deleted the add-iso-31661-numeric branch May 12, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants