added-53 and 25 to be valid ghana cell phone first 2 digits after dialin… #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2393 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 108 108
Lines 2482 2482
Branches 627 627
=========================================
Hits 2482 2482 ☔ View full report in Codecov by Sentry. |
WikiRik
requested changes
May 7, 2024
| @@ -41,7 +41,7 @@ const phones = { | |||
| 'en-BS': /^(\+?1[-\s]?|0)?\(?242\)?[-\s]?\d{3}[-\s]?\d{4}$/, | |||
| 'en-GB': /^(\+?44|0)7\d{9}$/, | |||
| 'en-GG': /^(\+?44|0)1481\d{6}$/, | |||
| 'en-GH': /^(\+233|0)(20|50|24|54|27|57|26|56|23|28|55|59)\d{7}$/, | |||
| 'en-GH': /^(\+233|0)(20|50|24|54|27|57|26|56|23|28|55|59|53|25)\d{7}$/, | |||
There was a problem hiding this comment.
According to https://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000520009PDFE.pdf only 2540, 256 and 257 are valid.
53 is fine.
|
@ubanitc can you also include the source? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(isMobilePhone): Adds 53 and 25 to to valid ghana cell phone first 2 digits after dialing code
Currently ghana phone numbers have 53 and 25 as the numbers starting their phone numbers. and when these numbers are inputted it throws an error saying that they are invalid. when in fact they are valid phone numbers. this PR is supposed to fix that and add the new numbers
for example:
+233593112756gets validated. but doesn't+233533830853Checklist