Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use pnpm #2391

Closed
wants to merge 1 commit into from
Closed

ci: use pnpm #2391

wants to merge 1 commit into from

Conversation

rubiin
Copy link
Member

@rubiin rubiin commented Apr 27, 2024

Updates the ci to use pnpm.
Also drops end of life nodejs versions which are too old

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@rubiin rubiin requested review from WikiRik and profnandaa April 27, 2024 14:42
@WikiRik
Copy link
Member

WikiRik commented Apr 27, 2024

Any reason why pnpm instead of npm (or yarn)?

Also; this is a breaking change so we'll need to do a major release for this

@rubiin
Copy link
Member Author

rubiin commented Apr 27, 2024

pnpm because its like a superset of npm . Most commands are similar .Also I use pnpm comparatively more.
I bet anyone would be using the node 16 and below, most libraries already dropped support for them. Supporting them would mean we have to use tools like babel to transform latest js features for older runtimes
But we will have to do a major release considering it might be a breaking change

@rubiin
Copy link
Member Author

rubiin commented May 9, 2024

closing this for now , will revisit later

@rubiin rubiin closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants