feat(isMobilePhone): add sr-ME locale #2225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todor46
changed the title
Todor46
force-pushed
the
feature/montenegro-locale-phone
branch
from
73d3ac5 to
12d663d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2225 +/- ##
===========================================
- Coverage 100.00% 99.95% -0.05%
===========================================
Files 108 107 -1
Lines 2482 2405 -77
Branches 627 604 -23
===========================================
- Hits 2482 2404 -78
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
Todor46
force-pushed
the
feature/montenegro-locale-phone
branch
from
12d663d to
59b9a6b
Compare
rubiin
requested review from
WikiRik and
pano9000
and removed request for
WikiRik
WikiRik
previously approved these changes
May 25, 2023
There was a problem hiding this comment.
Prefixes align with https://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000DA0002PDFE.pdf
rubiin
previously approved these changes
Jun 12, 2023
profnandaa
added
🎉 first-pr
mc-to-land
|
@Todor46 can you fix the merge conflicts |
rubiin
added
✅ LGTM
and removed
mc-to-land
rubiin
requested changes
Jun 1, 2024
profnandaa
added
🧹 needs-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated validator, test, and README to include Montenegro locale (sr-ME)
Reference for mobile phones:
https://en.wikipedia.org/wiki/Telephone_numbers_in_Montenegro
Checklist