Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(isCreditCard): create allCards dynamically and get rid of hard-to-maintain hardcoded version #2117

Merged
merged 2 commits into from
Jun 26, 2023
Merged

refactor(isCreditCard): create allCards dynamically and get rid of hard-to-maintain hardcoded version #2117

merged 2 commits into from
Jun 26, 2023

Commits on Dec 6, 2022

  1. refactor(isCreditCard): create allCards dynamically 

    get rid of the hardcoded allCards variable, which was a manual copy of the existing regExp for card provider.
Replace it with a dynamically created array instead, which will make it easier to maintain, when new providers are added.
    @pano9000
    pano9000 committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    5fa4108 View commit details
    Browse the repository at this point in the history

  2. chore: code coverage improvement 

    add "istanbull ignore else", similarly to how it is was done in:
9ee09a7
    @pano9000
    pano9000 committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    1ecdd21 View commit details
    Browse the repository at this point in the history