feat(isMobilePhone): en-GB enhance #1971
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1971 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 108 103 -5
Lines 2482 2097 -385
Branches 627 473 -154
==========================================
- Hits 2482 2097 -385 ☔ View full report in Codecov by Sentry. |
ihmpavel
changed the title
| @@ -34,7 +34,7 @@ const phones = { | |||
| 'el-GR': /^(\+?30|0)?(69\d{8})$/, | |||
| 'en-AU': /^(\+?61|0)4\d{8}$/, | |||
| 'en-BM': /^(\+?1)?441(((3|7)\d{6}$)|(5[0-3][0-9]\d{4}$)|(59\d{5}))/, | |||
| 'en-GB': /^(\+?44|0)7\d{9}$/, | |||
| 'en-GB': /^(\+?44|0)7[1-9]\d{8}$/, | |||
There was a problem hiding this comment.
@tux-tn and @profnandaa, do we need need to allow pagers and personal numbering as part of the phone numbers?
There was a problem hiding this comment.
what is personal numbering? Are people still using pagers these days?
profnandaa
added
the
🧹 needs-update
profnandaa
added
the
mc-to-land
|
@ihmpavel - possible to fix the merge conflict here? Should be okay to land after that. |
|
@ihmpavel can you fix the merge conflicts |
rubiin
added
mc-to-land
|
@rubiin Conflicts resolved |
|
It looks like |
rubiin
removed
the
mc-to-land
|
@ihmpavel -- we use it as maintainers to quickly scan through PRs are good but just need merge conflict resolutions. Sometimes we go ahead to resolve the conflicts ourselves when the authors are a bit unresponsive. |
Update mobile phone validation for
en-GB07should not be zeroChecklist
Inspired by #1164
Also I am wondering, whether support more phone numbers in the UK.
Quorra link with explanation https://qr.ae/pvAeI7