-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isPassportNumber, isIBAN, isMobilePhone): updated to validate Mozambique passport, Mobile and IBAN number; #1604
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1604 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 100
Lines 1847 1847
=========================================
Hits 1847 1847
Continue to review full report at Codecov.
|
I believe you should remove |
@salmento -- please fix the merge conflic and we should be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@salmento sorry we merged some other PRs, can you please fix the new conflicts?
Sure!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You left a trailing space in README.md
i removed it ! LGTM ! Thank you for the change and for your first PR 🎉
Thanks |
Sorry, another merge conflict :( |
{{ feat(isPassportNumber) and feat(isMobilePhone): updated to validate Mozambique passport number and mobile phone }}
Checklist