feat(isDivisbleBy): bug fix (probably) #1350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profnandaa
reviewed
Jun 8, 2020
There was a problem hiding this comment.
I think a can of worms has been opened, how will you explain these:
> 4.2 % 2
0.20000000000000018
The float-point territory is a complicated one, and I don't know why we even went with allowing floats for the dividend 🤔
If it were up to me, I'd strictly go for integers for both...
|
/cc. @HonzaKirchner ^ |
|
I hoped it could be solved by comparing to EPSILON... But even more strangely |
|
@profnandaa I totally forgot that, but I do wonder if that's the case how banks and other services work? That needs high precision |
|
@mum-never-proud they use special decimal datatypes and libraries like decimal.js |
|
Closing since #1354 is also closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unsure if this was intentional, i consider it as a valid bug
resolves #1349
Checklist