Chore clean 1034 #1085
Closed
Chore clean 1034 #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check if the string is IBAN number, (locale is one of ['AD','AT','BH','BE','BA','BG','CY','CZ','DE','DK','EE','FO','FI','FR','GB','GE','GI','GL','GR','HU','HR','IE','IS','IT',TN] OR defaults to 'any'. If 'any' or a falsey value is used, function will check if any of the locales match with the first two letters of the IBAN which coincide with the country Alpha-2 code name).
ezkemboi
force-pushed
the
chore-clean-1034
branch
2 times, most recently
from
9d24518 to
6497f8c
Compare
- fix linter issues - fix tests - seperate unnecessary files changes - closes validatorjs#1034 validatorjs#951 - Other references validatorjs#1071
ezkemboi
force-pushed
the
chore-clean-1034
branch
from
6497f8c to
1201453
Compare
|
Landed in #1243 // that was my bad, I'd forgot about this PR. Thanks for the contrib through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up PR #1034.
Make sure to add test for invalid isIBAN locale.