Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fase 5 #3

Open
6 tasks done
ilgrosso opened this issue Sep 26, 2022 · 1 comment
Open
6 tasks done

Fase 5 #3

ilgrosso opened this issue Sep 26, 2022 · 1 comment
Assignees

Comments

@ilgrosso
Copy link
Collaborator

ilgrosso commented Sep 26, 2022

@ilgrosso ilgrosso changed the title Fase 4 Fase 5 Sep 26, 2022
valerio-crescia added a commit that referenced this issue Nov 3, 2022
valerio-crescia added a commit that referenced this issue Nov 3, 2022
ilgrosso pushed a commit that referenced this issue Nov 4, 2022
@ilgrosso
Copy link
Collaborator Author

ilgrosso commented Nov 4, 2022

Osservazioni sullo stato dopo il commit c9d3af8:

  1. macano test specifici per LiveSync (sia unit sia integration)
  2. è stato modificato solo core/persistence-jpa/src/test/resources/domains/MasterContent.xml non core/persistence-jpa-json/src/test/resources/domains/MasterContent.xml
  3. il build non passava per errori checkstyle, ho fixato nel commit 10e67a9
  4. che cos'è LiveSyncDAO#findByEntityID? Non mi risulta che esista un campo del genere in JPALiveSync
  5. occorre estrarre un validator comune tra ExternalResource e LiveSync
  6. LiveSyncStreamPullJobDelegate#stream prende come argomento ResourceProvision? Perché non esiste LiveSyncProvision?

valerio-crescia added a commit that referenced this issue Nov 4, 2022
valerio-crescia added a commit that referenced this issue Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants