Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to LanguageTool subscription #398

Closed
mhalano opened this issue Aug 28, 2021 · 13 comments
Closed

Support to LanguageTool subscription #398

mhalano opened this issue Aug 28, 2021 · 13 comments
Assignees
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch
Milestone

Comments

@mhalano
Copy link

mhalano commented Aug 28, 2021

Note: Per the contribution guidelines, deleting parts of the template or not filling in vital information may result in the issue to be immediately closed as invalid.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Using actual real-world examples that explain why you and many other users would benefit from the feature increases the request's chances of being implemented.
I subscribed to the paid version of LanguageTool. It provides more complete suggestions than the basic version. I would like to be able to log in to my account and get these more complete suggestions, in the same way I do when I use the Firefox extension.

Describe the solution you'd like
A clear and concise description of what you want to happen.
Implement option to do the login and get the advanced suggestions available for subscribers.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Can't find any alternatives.

Additional context
Add any other context or screenshots about the feature request here.

@mhalano mhalano added the 1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature label Aug 28, 2021
@valentjn
Copy link
Owner

valentjn commented Aug 28, 2021

Unless you're a subscriber of the API plan, this is a duplicate of #18, i.e., this is not possible with a simple Premium plan of LanguageTool. You need an API plan instead, as only this plan allows third-party access to LanguageTool Premium. See also the docs.

@valentjn valentjn added the 3-duplicate Issue resolution: Issue has been submitted before label Aug 28, 2021
@mhalano
Copy link
Author

mhalano commented Aug 28, 2021

I opened an issue with the developer so we could find a way to query using login options to get answers using the premium features. languagetool-org/languagetool#5587

@valentjn
Copy link
Owner

You can open an upstream issue, but as I said, you have to subscribe to an API plan for this to work (for me, it says EUR 29 per month for 100 checks per day). It's simply not allowed in the normal Premium plan for external software to access LT Premium features via HTTP. That's what the API plan is for.

@mhalano
Copy link
Author

mhalano commented Aug 29, 2021

@valentjn I got an API key. But I just could set the API endpoint, not the API key. There is an option which just can be set editing the JSON config file?

@valentjn
Copy link
Owner

Ah, I see. This has to be implemented on LTEX side. Sorry for the confusion.

@valentjn valentjn reopened this Aug 29, 2021
@valentjn valentjn removed the 3-duplicate Issue resolution: Issue has been submitted before label Aug 29, 2021
valentjn added a commit to valentjn/ltex-ls that referenced this issue Aug 29, 2021
valentjn added a commit that referenced this issue Aug 29, 2021
@valentjn valentjn self-assigned this Aug 30, 2021
@valentjn valentjn added this to the 11.1.0 milestone Aug 30, 2021
@valentjn
Copy link
Owner

ltex.ltex-ls.languageToolOrgUsername and ltex.ltex-ls.languageToolOrgApiKey are now implemented. @mhalano Can you try the nightly to see if it's working? I don't have an API key.

@mhalano
Copy link
Author

mhalano commented Aug 30, 2021

@valentjn Installed the nightly version and configured username and API key. What can I do to check if the extension is querying the API endpoint correctly?

@valentjn
Copy link
Owner

valentjn commented Aug 30, 2021

Check sentences that contain diagnostics that only LanguageTool Premium discovers. Their website contains some examples:

He was very afraid of the consequences.
If that's not possible what are our options?
The children have been saved by the police.
etc.

I don't get a diagnostic for any of these (without API key). You might want to set ltex.checkFrequency to "manual" first to avoid hitting your rate limit.

@mhalano
Copy link
Author

mhalano commented Aug 30, 2021

I thought it had a debug option to describe the connection process. I got two of three corrections. Seems good to me. What do you think? Can we mark as solved?
image

@valentjn
Copy link
Owner

valentjn commented Aug 30, 2021

Excellent, it seems to be working. It might be that some of those examples only work when activating picky rules via ltex.additionalRules.enablePickyRules, or when enabling the corresponding rules manually via ltex.enabledRules.

The documentation will be updated to include the new settings once released. Thanks for the feature request.

@valentjn valentjn added the 3-fixed Issue resolution: Issue has been fixed on the develop branch label Aug 30, 2021
@valentjn
Copy link
Owner

Feature released in 12.0.0.

@melsophos
Copy link

Just for reference for people who need it (see also #18), it is possible to request an API key as a Premium user by contacting the support, there is no need to have a developer plan.

@bobek
Copy link

bobek commented Nov 30, 2022

Just for the reference, it seems that you don't need to contact support anymore. There is a settings page, which allows for generating the token directly:

image

I had to set languageToolHttpServerUri to https://api.languagetoolplus.com (without v2).

me-johnomar added a commit to me-johnomar/ltex-ls that referenced this issue Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch
Projects
None yet
Development

No branches or pull requests

4 participants