Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to add "wrong form" word to dictionary #221

Closed
BelKed opened this issue Jan 14, 2021 · 7 comments
Closed

Add possibility to add "wrong form" word to dictionary #221

BelKed opened this issue Jan 14, 2021 · 7 comments
Assignees
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch
Milestone

Comments

@BelKed
Copy link

BelKed commented Jan 14, 2021

Is your feature request related to a problem? Please describe.
As title says, I would like to add possibility to add "wrong form" word to dictionary.
When I write in Slovak language, there is no possibility like that. You could see that on this screenshot:
picture
Also, there is screenshot of that problem in bottom section of Visual Studio Code:
bottom section
Translation of text is following:
Incorrect adjective shape (optických)
'optický'

Describe the solution you'd like
I would like to add possibility to Add 'word' to dictionary to dropdown menu like is there:
kalorimetrickej

I hope, I wrote that issue understandable.
PS: Thanks for your super extension, it's really helpful for searching for almost invisible typos 😃

@BelKed BelKed added the 1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature label Jan 14, 2021
@valentjn valentjn self-assigned this Jan 15, 2021
@valentjn valentjn added this to the 8.3.0 milestone Jan 15, 2021
valentjn added a commit to valentjn/ltex-ls that referenced this issue Jan 15, 2021
@valentjn
Copy link
Owner

Thanks for the feature request! I enabled the quick fix not only for the rule MUZSKY_ROD_NEZIV_A, but also for ZENSKY_ROD_A and STREDNY_ROD_A, as I think these rules are similar (just different genders). I don't know Slovak though.

I also removed the superfluous whitespace in the message of the rules, as the messages of most other languages are given in a single line without any indentation.

@valentjn valentjn added the 3-fixed Issue resolution: Issue has been fixed on the develop branch label Jan 15, 2021
@BelKed
Copy link
Author

BelKed commented Jan 15, 2021

Thanks for the fix.

I enabled the quick fix not only for the rule MUZSKY_ROD_NEZIV_A, but also for ZENSKY_ROD_A and STREDNY_ROD_A, as I think these rules are similar (just different genders).

Yes, you are right, these are rules are similar. They are just different genders...

@valentjn
Copy link
Owner

Fix released in 8.3.0.

@BelKed
Copy link
Author

BelKed commented Jan 24, 2021

Now I could add the "wrong" form of word to dictionary, but LTeX still underlines that word in document and shows the error...

@valentjn valentjn reopened this Jan 24, 2021
@valentjn valentjn removed the 3-fixed Issue resolution: Issue has been fixed on the develop branch label Jan 24, 2021
@BelKed
Copy link
Author

BelKed commented Jan 24, 2021

Thanks 😄

@valentjn valentjn added the 3-fixed Issue resolution: Issue has been fixed on the develop branch label Jan 24, 2021
@valentjn
Copy link
Owner

Fix released in 8.4.0.

@BelKed
Copy link
Author

BelKed commented Jan 30, 2021

Really thanks, now it works 😃

me-johnomar added a commit to me-johnomar/ltex-ls that referenced this issue Jan 31, 2024
me-johnomar added a commit to me-johnomar/ltex-ls that referenced this issue Jan 31, 2024
me-johnomar added a commit to me-johnomar/ltex-ls that referenced this issue Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch
Projects
None yet
Development

No branches or pull requests

2 participants