Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more context (e.g., for possible spelling mistake) #161

Closed
yzhang-gh opened this issue Nov 4, 2020 · 3 comments
Closed

Show more context (e.g., for possible spelling mistake) #161

yzhang-gh opened this issue Nov 4, 2020 · 3 comments
Assignees
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch
Milestone

Comments

@yzhang-gh
Copy link

Thanks for your great work!

Is your feature request related to a problem? Please describe.

I usually use the Problems panel to review all the warnings

image

However, I need to click on every entry to check if I really need to change it. (For example, author names are reported as spelling mistakes.)

It would be better to also show the word with the warning message. (See the line above the annotation, it is a message from Spell Right extension.)

I guess there are other types of diagnostic that will benefit from this.

@yzhang-gh yzhang-gh added the 1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature label Nov 4, 2020
@valentjn valentjn self-assigned this Nov 4, 2020
@valentjn valentjn added this to the 8.1.0 milestone Nov 4, 2020
@valentjn
Copy link
Owner

valentjn commented Nov 4, 2020

This issue would be better directed at microsoft/vscode (i.e., how VS Code displays problems) or microsoft/language-server-protocol. There's only one type of message for diagnostics, regardless of whether you hover over the problem in the editor, or look at it in the Problems tab. LTEX won't include context for most diagnostic types because then there would be a lot of redundant info when hovering in the editor (as in this case, you have the context directly near your mouse cursor). Plus, the context can be longer for a grammar checker like LT/LTEX (where a whole subordinate clause might be underlined) than for simple spell checkers (the same holds for the messages themselves), and the Problems tab will crop too long entries.

I implemented this for "unknown word" LT rule types (thanks for the suggestion), but I'm not convinced this would be a good thing to do for other rule types.

@valentjn valentjn added the 3-fixed Issue resolution: Issue has been fixed on the develop branch label Nov 4, 2020
@yzhang-gh
Copy link
Author

Many thanks 👍

@valentjn
Copy link
Owner

Fix released in 8.1.0.

valentjn added a commit to valentjn/ltex-ls that referenced this issue Jan 24, 2021
me-johnomar added a commit to me-johnomar/ltex-ls that referenced this issue Jan 31, 2024
me-johnomar added a commit to me-johnomar/ltex-ls that referenced this issue Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch
Projects
None yet
Development

No branches or pull requests

2 participants