Expand accent support #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2021
valentjn
approved these changes
Apr 4, 2021
|
Thanks for the great PR. I looked up every single character in the Unicode table, and all of them were correct. You don't really need advanced Java skills to add tests, as you can usually just amend one of the existing tests. You just need to know where to look. |
|
Released in 11.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase coverage of accents where precomposed unicode letters exist.
Unicode is quite big and I haven't added everything with a precomposed character, but these additions fix several problems with Polish (a language supported by LanguageTool) and Hungarian (not supported, but Hungarian names get used even when writing other languages).
I've carefully checked that all the code points inserted correspond to the correct thing, but since I'm very new to this code it would be worth checking the surrounding logic carefully. I guess some tests designed to check accent command substitution would be nice, but that's beyond my java skills.
Fixes #56.