Skip to content

[harness eval #34752] fix: add ariaLabel support to ActionItem interface #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valentinpalkovic wants to merge 1 commit into
base: next
Choose a base branch
from
+10 −2
Open

[harness eval #34752] fix: add ariaLabel support to ActionItem interface #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions code/addons/docs/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ type CanvasBlockParameters = {
disabled?: boolean;
onClick: () => void;
title: string | React.JSX.Element;
ariaLabel?: string | false;
}[];
/** Provide HTML class(es) to the preview element, for custom styling. */
className?: string;
Expand Down
11 changes: 9 additions & 2 deletions code/core/src/components/components/ActionBar/ActionBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ export interface ActionItem {
className?: string;
onClick: (e: MouseEvent<HTMLButtonElement>) => void;
disabled?: boolean;
ariaLabel?: string | false;
}

export interface ActionBarProps {
Expand All @@ -89,8 +90,14 @@ export interface ActionBarProps {
export const ActionBar = ({ actionItems, flexLayout = false, ...props }: ActionBarProps) => {
return (
<Container {...props} $flexLayout={flexLayout}>
{actionItems.map(({ title, className, onClick, disabled }, index: number) => (
<ActionButton key={index} className={className} onClick={onClick} disabled={!!disabled}>
{actionItems.map(({ title, className, onClick, disabled, ariaLabel }, index: number) => (
<ActionButton
key={index}
className={className}
onClick={onClick}
disabled={!!disabled}
aria-label={ariaLabel === false ? undefined : ariaLabel}
>
{title}
</ActionButton>
))}
Expand Down
Loading