chore: verify-harness A4 label-fire test (fork)#1
Closed
valentinpalkovic wants to merge 1 commit into
Closed
Conversation
No-op touch to trigger PR Verification Harness workflow within valentinpalkovic/storybook fork. Avoids noise on upstream OSS repo. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
valentinpalkovic
added
ci:verify
Verify HarnessNo verdict produced (workflow failed before harness ran). See run log. |
valentinpalkovic
added
ci:verify
Verify HarnessNo verdict produced (workflow failed before harness ran). See run log. |
valentinpalkovic
added
ci:verify
Verify HarnessNo verdict produced (workflow failed before harness ran). See run log. |
valentinpalkovic
added
ci:verify
Verify HarnessNo verdict produced (workflow failed before harness ran). See run log. |
valentinpalkovic
added
ci:verify
Verify HarnessNo verdict produced (workflow failed before harness ran). See run log. |
Owner
Author
|
A4 gate complete. Closing — workflow validated 7/8 steps. Remaining: v5-0 Dockerfile gap, tracked on storybookjs#34762. |
valentinpalkovic
added a commit
that referenced
this pull request
May 18, 2026
…ActionBar scope Wave findings (#28/#29/#31 stuck at regression despite passing PR unit tests — recipe-author mis-targeted the DOM): - ActionBar/Canvas rule was conflating the docs-Canvas Zoom/Show-code toolbar with the generic `ActionBar` component. Scope-tagged it to the docs-Canvas surface only. - New HARD GATE "additive-only API changes with no story/consumer" — the #1 false-regression cause. #28/#29 add `ActionItem.ariaLabel` but no story or in-diff consumer passes it, so the attribute is never in the DOM; asserting it always fails. Rule: detect additive-no-consumer, fall back to `@verify-mode: visual` smoke on the component's existing story (`components-actionbar--many-items`), never `getByRole('toolbar')` (the component renders plain <button>s) nor `.docs-story`. - New HARD GATE for `Brand` / `theme.brand.title`: the sanitized dangerouslySetInnerHTML path runs ONLY when `theme.brand.image === null`. Target the existing `manager-sidebar-heading--only-text` / `--link-and-text` stories (already `{title, image:null}`); never runtime `api.setOptions({theme})` (#31 false regression — never reaches the path). XSS-inert proof is the PR's unit test; recipe is a render/boot smoke. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A4 activation gate test. Do not merge.