Skip to content

Update valence to mc1.20.4 #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Bafbi wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Update valence to mc1.20.4 #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e0df823
Update extractor to mc1.20.4
Bafbi Jan 23, 2024
1e6f30b
Create devcontainer.json
Bafbi Jan 28, 2024
ba1d364
Repare packets
Bafbi Jan 28, 2024
a326719
Add new configurations packets
Bafbi Jan 29, 2024
e87d124
register new packets + fix simple error
Bafbi Jan 29, 2024
9e19f93
Implement new packets + rename changed one + update packet inspector
Bafbi Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
Comment thread
dyc3 marked this conversation as resolved.
"image": "mcr.microsoft.com/devcontainers/universal:2",
"features": {
"ghcr.io/devcontainers/features/rust:1": {},
"ghcr.io/devcontainers/features/java:1": {
"version": "17",
"installGradle": true
}
}
}
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ opt-level = 1

[workspace]
members = ["crates/*", "tools/*"]
# members = ["crates/*", "tools/playground"]
exclude = []
resolver = "2"

Expand Down
3 changes: 2 additions & 1 deletion crates/valence_advancement/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,9 @@ impl<'w, 's, 'a> Encode for AdvancementUpdateEncodeS2c<'w, 's, 'a> {
}
}

// ???? wtf ????
impl<'w, 's, 'a> Packet for AdvancementUpdateEncodeS2c<'w, 's, 'a> {
const ID: i32 = packet_id::ADVANCEMENT_UPDATE_S2C;
const ID: i32 = packet_id::PLAY_ADVANCEMENT_UPDATE_S2C;
const NAME: &'static str = "AdvancementUpdateEncodeS2c";
const SIDE: PacketSide = PacketSide::Clientbound;
const STATE: PacketState = PacketState::Play;
Expand Down
Loading