Add default fields for all entities in extractor#571
Closed
SelfMadeSystem wants to merge 12 commits intovalence-rs:mainfrom
SelfMadeSystem:fix-extractor
Closed
Add default fields for all entities in extractor#571SelfMadeSystem wants to merge 12 commits intovalence-rs:mainfrom SelfMadeSystem:fix-extractor
SelfMadeSystem wants to merge 12 commits intovalence-rs:mainfrom
SelfMadeSystem:fix-extractor
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
perhaps not as crazy as I initially thought |
rj00a
approved these changes
Oct 22, 2023
rj00a
reviewed
Oct 24, 2023
Member
rj00a
left a comment
rj00a
left a comment
There was a problem hiding this comment.
Nice work!
I suspect bevy is not going to be happy about the huge number of systems being scheduled now. Each system has some constant overhead, especially with the multithreaded executor. You could try merging the systems together, but this is one problem I'm trying to address with my new ECS library.
…s, but removed the default.
rj00a
added a commit
that referenced
this pull request
Feb 16, 2024
Fixed some bugs and added proper default values for fields. Partially adapted from #571. Co-authored-by: SelfMadeSystem <sms@shoghisimon.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution