[#1677] Add multi-server transaction submission#34
Closed
czarcas7ic wants to merge 2 commits into
Closed
Conversation
15 tasks
205f176 to
a07749f
Compare
6e24219 to
dfee2c8
Compare
czarcas7ic
commented
May 4, 2026
| .package(url: "https://github.com/pointfreeco/swift-url-routing", from: "0.6.2"), | ||
| .package(url: "https://github.com/zcash-hackworks/MnemonicSwift", from: "2.2.5"), | ||
| .package(url: "https://github.com/zcash/zcash-swift-wallet-sdk", from: "2.4.9"), | ||
| .package(path: "../../zcash-swift-wallet-sdk"), |
Author
There was a problem hiding this comment.
This will change once zcash/zcash-swift-wallet-sdk#1678 is merged and tagged.
a07749f to
129d50f
Compare
Create transactions locally with the SDK Broadcaster API, then broadcast each transaction to the selected endpoint set with first-success semantics. Add regular and PCZT coverage for the new send flow and document the draft SDK dependency state in the PR body.
dfee2c8 to
8829050
Compare
Author
|
Closing in favor of zodl-inc#1751 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: zodl-inc#1677
Depends on the auto/manual connection-mode branch.
Depends on the merged Swift SDK Broadcaster API work for the new SDK APIs.
Summary
Draft dependency note:
Package.swiftintentionally uses a local SDK path while this PR waits for a tagged Swift SDK release containing the Broadcaster APIs. The upstream merge commit is348a9dfff2604f986590c64272ce12dd4a83c943, but pinning that commit directly is not buildable yet because the SDK source currently expects unpublishedlibzcashlcsymbols. Before merge, this should be switched back to the tagged SDK release once available.Behavior note: Per-transaction partial-submit status is no longer stored in
SendConfirmationstate. If a later transaction in a multi-transaction proposal fails after local creation, the send flow falls back to the existing pending/failure result presentation instead of surfacing per-transaction status strings.Testing
git diff --checkswift package --package-path modules dump-packagexcodebuild -list -project secant.xcodeprojxcodebuild testis currently blocked before zodl code by the untagged SDK package artifact mismatch described above.Video from testing:
https://screen.studio/share/1mgC0NYH
If you check the logs in the video, we can see a perfect example of why this feature is good, as one of the endpoints was faulty with an Orchard anchor error, but the other endpoints successfully submitted it.
Author
Reviewer