Bump zcash_voting to 0.5.8 — bundle identity persistence, HTTP runtime drop fix#46
Merged
Merged
Conversation
79b597d to
facc4d6
Compare
13 tasks
Persist bundle note identities as the core security boundary for Swift and Android consumers, and reject substituted notes across PCZT, PIR, and proof entry points. Keep legacy position-only rows compatible while making setup/proof persistence atomic so SDK wrappers do not need sidecar transaction logic.
p0mvn
approved these changes
May 11, 2026
1f937dc to
6654557
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two release-blocking issues for the upcoming governance flow:
Bundle note identities can drift after setup.
setup_bundlesonly recordednote positions, so if the same position later resolved to a different note,
governance PCZT construction would silently sign over substituted inputs.
Persisting full identity hashes and rejecting same-position substitutions
closes that window.
HTTP transport panicked when dropped under Tokio. The tree-sync feature
builds a multi-thread Tokio runtime inside
HyperTransport. Dropping itfrom inside an active Tokio context (which happens during normal teardown
on the wallet side) trips Tokio's "drop runtime in async context" panic.
Wrapping it in a
BlockingRuntimethat callsshutdown_backgroundon dropavoids the panic without changing call-site behavior.
Migration
Adds DB schema v8: new
bundles.note_identity_hashes_blobcolumn. Existingrows are preserved with
NULLidentity hashes; the column is also part of001_init.sqlso fresh databases get it directly. Migration is idempotent(guards on
column_exists).Tests
cargo test -p zcash_voting storage::— covers the v7→v8 migration pathand identity-hash persistence/readback.
cargo test -p zcash_voting --features client-tree-sync blocking_runtime_drop_does_not_panic_inside_tokio_context— regression test for the runtime drop panic.