Add delegation PIR precompute cache#31
Merged
Merged
Conversation
This was referenced May 1, 2026
czarcas7ic
requested changes
May 1, 2026
Contributor
czarcas7ic
left a comment
czarcas7ic
left a comment
There was a problem hiding this comment.
If you run cargo test --workspace, there are 20 failing storage tests from the db migration that was added.
As a drive by we should add this to our CI so we catch it
Migration to version 7 added imt_proofs to 001_init.sql, but the v3/v4/v5/v6 drop-all-recreate blocks didn't include it in their DROP TABLE list. On a fresh DB migrating up through every version, v3 succeeded (creating imt_proofs from the new init.sql), then v4's re-run of init.sql collided on CREATE TABLE imt_proofs and panicked all 20 storage tests that go through the test_db helper. Add the drop and a comment on v3 noting that future drop-all migrations have to cover every table currently in 001_init.sql.
The repo only had a lockfile guard workflow, so the v7 migration regression that broke 20 storage tests went undetected on the PR. Add a minimal test job that runs cargo test --workspace --locked on push and PR.
czarcas7ic
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
precompute_delegation_pirfor real-note and padded-note nullifier proofsTesting
cargo check -p zcash_votingNotes
This keeps the PIR proof validation added in #30 and applies it before cached proofs are persisted.