chore: commit Cargo.lock, consolidate deps (P6/P7/P9)#13
Merged
Conversation
czarcas7ic
force-pushed
the
adam/p6-p9-lockfile
branch
3 times, most recently
from
b6146c2 to
e420082
Compare
p0mvn
reviewed
Apr 10, 2026
…atches (P6/P7/P9) - Remove Cargo.lock from .gitignore and commit it for reproducible builds. librustvoting was the only repo in the dependency graph without a committed lockfile, allowing silent dep drift (P9). - Switch vote-commitment-tree's imt-tree dep from a bare git URL to the now-published crates.io v0.1.0 (P6). - Pin pir-client by rev (vote-nullifier-pir@b06d093) which switches imt-tree deps to crates.io and fixes the ypir/spiral-rs package renames using `package = "valar-ypir"` / `package = "valar-spiral-rs"`, keeping the audited valargroup forks. - Switch librustzcash patches from floating branch "valargroup/pczt-governance-extensions-0.11" to rev-pinned "shielded-voting-wallet-support" HEAD (e0ff19d) (P5/P7). - Add CI guard (.github/workflows/lockfile.yml) that fails if Cargo.lock is missing, preventing regression.
czarcas7ic
force-pushed
the
adam/p6-p9-lockfile
branch
from
e420082 to
5850d23
Compare
p0mvn
approved these changes
Apr 10, 2026
Main added zcash_client_sqlite to [patch.crates-io] and new deps (zcash_client_sqlite, shardtree) to librustvoting. Merged with our rev-pin approach — all librustzcash patches now pinned to shielded-voting-wallet-support HEAD (6858db4).
This was referenced Apr 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo.lockfor reproducible builds (P9 fix -- librustvoting was the only repo without one)imt-treeto published crates.io v0.1.0 (P6 fix -- eliminates namesquatting risk and double-compile)shielded-voting-wallet-supportHEAD by rev (P5/P7 fix -- consolidates the two parallel branches)pir-clientby rev to vote-nullifier-pir@b06d093 which switches workspace imt-tree deps to crates.io and fixes the ypir/spiral-rs package renames usingpackage = "valar-ypir"/package = "valar-spiral-rs"(keeps the audited valargroup forks)Cargo.lockis missingContext
Sean's review identified that librustvoting was the sole repo without a committed lockfile, the
imt-treecrate was unregistered on crates.io, and librustzcash patches were floating on a branch recommended for deletion. This PR addresses all three in one shot.Dependencies
Test plan
cargo test --workspace-- 125 tests pass (84 librustvoting, 12 vote-commitment-tree, 11+10 integration, 8 client)grep -c '^name = "imt-tree"' Cargo.lockreturns1pczt-governance-extensions-0.11in lockfile[patch."https://github.com/valargroup/vote-nullifier-pir.git"]workaround needed