Call standalone witness generation instead of wallet_db method#16
Merged
Conversation
The witness generation logic lives in librustvoting's orchard_witnesses module. Call it directly with the DB connection rather than going through a method on the wallet DB type, which removes an unnecessary coupling to the zcash_client_sqlite API surface. Made-with: Cursor
Author
|
Note: CI will be fixed after the following are merged: |
czarcas7ic
approved these changes
Apr 10, 2026
Pick up the merged dependency PRs: - librustvoting#14 (Orchard witness generation from wallet shard data) - librustzcash#23 (expose commitment-tree primitives) Made-with: Cursor
greg0x
pushed a commit
that referenced
this pull request
Apr 13, 2026
Call standalone witness generation instead of wallet_db method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_orchard_witnesses_at_frontiercall from thewallet_dbmethod to the standalone function invoting::orchard_witnesses, passing the DB connection directlyzcash_client_sqliteAPI surface — the logic lives in librustvoting and doesn't need to go through the wallet DB type