[#1924] Add zcash_voting dependency foundation#4
Closed
greg0x wants to merge 1 commit into
Closed
Conversation
Bring the Android Rust backend onto the released zcash_voting dependency line needed for shielded voting while keeping the initial JNI surface intentionally narrow. The exposed VotingRustBackend.computeShareNullifier symbol is a pure linkage check over caller-supplied bytes. It proves Android can resolve, link, and dispatch into zcash_voting without adding wallet database access, voting database lifecycle, PIR or tree-sync networking, or a public SDK voting API. orchard is pinned to =0.13.1 with the unstable-voting-circuits feature enabled, matching the Swift foundation split shape. No fork URLs or patch entries are introduced.
Author
|
opened upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs zcash#1924.
Associated issue: zodl-inc/zodl-android#2193.
Android analogue of zcash/zcash-swift-wallet-sdk#1699.
Summary
zcash_voting 0.5.3tobackend-libwith default features disabledorchardto=0.13.1withunstable-voting-circuitsVotingRustBackend.computeShareNullifier, to prove dispatch intozcash_votingCargo.lockandCHANGELOG.mdNon-goals
Testing
cargo check --lockedcargo fmt --checkcargo metadata --locked --format-version 1cargo tree -e features -i zcash_voting --locked./gradlew :backend-lib:compileReleaseKotlin./gradlew :backend-lib:cargoBuild./gradlew checkProperties ktlint detektAllgit diff --check