feat: widen visibility on orchard_internal items used by voting-circuits#15
Closed
czarcas7ic wants to merge 1 commit into
Closed
feat: widen visibility on orchard_internal items used by voting-circuits#15czarcas7ic wants to merge 1 commit into
czarcas7ic wants to merge 1 commit into
Conversation
Makes the items voting-circuits needs reachable from outside the crate. Every change has a concrete call site in voting-circuits. Doesn't touch the sealed SigType trait in primitives::redpallas or the public `orchard` wrapper crate. SpendAuthG/ElGamal widenings are in a separate PR.
czarcas7ic
force-pushed
the
adam/narrow-visibility-for-voting-circuits
branch
from
101ffb3 to
2c3633d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
pub/pub modchange has a concrete call site in voting-circuits.Verified
cargo check --workspace --all-targetscleanvalar-orchard(which voting-circuits currently compiles against) — no gaps