5/5: Tests and changelogs for External-IVK-only scanning#18
Closed
czarcas7ic wants to merge 1 commit into
Closed
Conversation
4d1cac0 to
672d9e2
Compare
24f69e7 to
f064551
Compare
672d9e2 to
efed8ea
Compare
d804c36 to
85a3f9f
Compare
ffa0e46 to
24eaddb
Compare
85a3f9f to
e4776e2
Compare
24eaddb to
a3894d5
Compare
e4776e2 to
b78d82c
Compare
473bc4e to
ec7a7d5
Compare
338e586 to
83ecd1c
Compare
ec7a7d5 to
d9afb68
Compare
f5be9f0 to
d649179
Compare
be777ea to
8f4571d
Compare
d649179 to
aaa5506
Compare
8f4571d to
30cfe08
Compare
77ea983 to
47544c5
Compare
30cfe08 to
50464a2
Compare
Switch scan_cached_blocks to External-only IVKs, halving key-agreement work. Change notes are recovered via enhancement. Includes conditional nullifier pruning in scan_cached_blocks and comprehensive test rewrites. Co-Authored-By: Claude <noreply@anthropic.com>
50464a2 to
8975f37
Compare
47544c5 to
abaff6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestState::enhance_transaction()andservice_enhancement_requests()helpers that mirror the production enhancement pipeline more closelyTestStateso serviceable enhancement requests are replayed from a production-like raw-transaction source instead of depending on wallet-visible raw stateservice_enhancement_requests()so it fails on missing raw bytes for serviceable enhancement work and detects stabilized serviceable queues, while still tolerating compact-only enhancement requests that the harness cannot reconstructenhance_transaction()so bundle positions are only derived when the tx is actually present in the cached compact block; otherwise it degrades or fails cleanly instead of fabricatingTxBundlePositionsv_transactions_hides_unenhanced_txsfunding-transaction checkenhancement_cascade_survives_pruning,v_transactions_hides_unenhanced_txs, andpruning_wipes_late_discovered_spend_locatortestsservice_enhancement_requests()after generating blocksContext
This is PR 5/5 — tests proving the full system works end-to-end. The changelog ownership was pushed down into the earlier branches during the fix round, so this final slice is now focused on test harness fidelity and end-to-end regressions.
Full stack:
adam/enriched-decrypted-output— API foundationsadam/sync-enhancement-pipeline— Core behavioral changeadam/sqlite-enhancement-support— SQLite backend implementationadam/memory-backend-enhancement— Memory backend implementationReview focus
enhance_transaction()helper fidelity relative to the productionstore_raw_transactionpathservice_enhancement_requests()and how it distinguishes serviceable enhancement requests from compact-only onesTest plan
cargo check -p zcash_client_backend --all-featurescargo test -p zcash_client_sqlite --features "sync orchard" can_spend_inputs_by_confirmations_policycargo test -p zcash_client_sqlite --features "sync orchard" v_transactions_hides_unenhanced_txscargo test -p zcash_client_sqlite --features "sync orchard" enhancement_cascade_survives_pruningcargo test -p zcash_client_memory --all-features