-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set attrib layer #58
set attrib layer #58
Conversation
I doubt this is correct logic. You have |
I wrote this logic because I only needed to check which block and layer and attribute definition the attribute corresponds to. |
I still cannot understand. Here you populate
The values here will be constantly overridden, since multiple inserts in a file can refer to the same block. So by the end of this loop, the map will contain just last |
this.blocks this.insert Comparing the two, the correct layer data does not exist in this.blocks object. And even if blockCtx is null, we need to find a definition outside of this block to specify the layer. |
You are right, this logic is wrong. Looks like I'll have to make a new one. |
f4cb30a
to
151b7de
Compare
attrib shows that it is related to attdef and block.
I realized that if I properly associate tag and name, I could get the right layer, and I implemented it. Please confirm.