Various MText improvements and small fixes #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_ProcessInsert` calls this method with a temporary entity which always has the `color` property, but it might be `undefined`. Returning `undefined` as the color will cause problems later. Therefore, we now just check if the color property exists and is not undefined.
|
@vagran Have you looked at this yet? |
I took a look, and found it is quite a lot of changes from various areas. So it is still postponed for full review and most probably some refactoring, understanding and testing each change. PR has higher chance to be merged quickly if it fixes some single problem. |
|
Ok, no problem. Just didn't want to let this go to waste |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost forgot about this, I hope the commits are somewhat self-explanatory. Let me know if anything should be changed, although I never want to work with JS again. Would be great to see the TS port and new parser completed.
I used https://github.com/mozman/ezdxf/blob/master/docs/source/dxfinternals/entities/mtext.rst and https://github.com/skymakerolof/dxf/blob/develop/src/handlers/entity/mtext.js as references to figure stuff out and of course just playing around in AutoCAD.
I've attached a file which can be used to compare the before and after, mostly regarding MText columns.
AutoCAD reference:
columns-all.dxf.txt