Rework parsing keyboard input in useInput
#576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimdemedes
changed the title
useInputuseInput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #409.
After working several days on figuring out and fixing all of the input parsing issues in
useInput, I realized I'm just patching holes all the time and not really sure if I'm introducing more bugs with each change.So I bailed on this and decided to copy the code from enquirer, which I believe adapted it from keypress, which extracted it from Node.js itself.
I disabled linter on
src/parse-keypress.tsto avoid fixing a lot of the issues it reported, which would make it harder to merge upstream changes.