Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #340.
In the following scenario, border wouldn't be rendered after the update happens:
It was happening because Ink's reconciler passes down only props that were changed during an update (https://github.com/vadimdemedes/ink/blob/master/src/reconciler.ts#L160) and in this case,
borderStyle
remained unchanged so it was missing when Ink drew a layout. If Ink doesn't seeborderStyle
, it's not going to render the border - https://github.com/vadimdemedes/ink/blob/master/src/render-border.ts#L7.To fix it, I modified reconciler's
prepareUpdate
function to always includeborderStyle
andborderColor
if at least one of them is present. Now ifborderStyle
stays unchanged, butborderColor
changes, both props will be included in the update.