Don't error on empty string input to <Color> #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though only dev error, it's convenient to not have to guard against temporarily empty strings getting passed to <Color>. Obviously, this is just a suggestion and one of many ways to implement. It's easy enough to write a wrapper around <Color> to handle this if that's preferred. The specific use case is rendering of fields in color that may, at times, be empty strings.
|
Could you add a test for it? Also, CI is failing. |
Color shouldn't throw if it receives undefined children.
|
I think everything looks good now. I added a test adjacent to another Color test. Not sure if that's the best place for it. Let me know if any other problems. Sorry for the multiple commits. Wasn't in a position to easily manage them. |
|
LGTM, thanks! |
jedahan
pushed a commit
to jedahan/ink-1
that referenced
this pull request
Sep 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though only dev error, it's convenient to not have to guard against temporarily empty strings getting passed to .
Obviously, this is just a suggestion and one of many ways to implement. It's easy enough to write a wrapper around to handle this if that's preferred.
The specific use case is rendering of fields in color that may, at times, be empty strings.
I don't use Typescript, so sorry if this breaks something in that world.