Add option to control selected index from outside of the component #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By taking in the index as a prop, we can control the selected index from outside of the component.
By passing the nextSelectedIndex to onHighlight, we can keep an index state outside of the component up-to-date
When index was undefined, the effect would overwrite the initialIndex state. This fixes that issue, although the index still overwrites the initialIndex if it does exist.
Before it would not be possible to set the index to zero, due to it being falsy
Co-authored-by: Vadim Demedes <[email protected]>
|
@vadimdemedes I've added tests and documentation, but I'm having problems with the prettier. It is giving me an error: |
|
@dnnsmnstrr Could you try deleting |
|
Also, feel free to mark this PR as ready when it's ok to start reviewing it. |
* upstream/master: 5.0.0 Migrate to ESM and Ink 4 (vadimdemedes#46) 4.2.2 Refresh dependencies Fix stuck selection when `initialIndex` is larger than `limit` (vadimdemedes#44) 4.2.1 Update peer dependencies to allow React 17.x (vadimdemedes#37) Fix old version link in readme 4.2.0 Reset selected item only when list values change (vadimdemedes#33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(creating this as a new pull request for it to count to my hacktoberfest contributions)
These changes were made because I wanted to keep the index state in a parent component, so it could listen for user input and a matching option could be highlighted by setting the state.
When the index prop changes, its value will be used for the selectedIndex, and by passing the nextSelectedIndex to the onHighlight function, that outside state can be kept up-to-date.