-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript template #5
Conversation
BTW, I can add the component creating support on another PR. $ create-ink-app --component
# or
$ craete-ink-component |
Have some minor comments, but great work overall!
I think it'd better fit in a |
Co-authored-by: Vadim Demedes <[email protected]>
Co-authored-by: Vadim Demedes <[email protected]>
Co-authored-by: Vadim Demedes <[email protected]>
Co-authored-by: Vadim Demedes <[email protected]>
Hey @LitoMore, I'm getting this error when running
|
Fixed. BTW, I can also enhance our CI to test the generated app. Should I add the generated app test in this PR or open a new PR? |
Good idea, let's do it in a separate PR ;) |
OK, now this PR is done. |
There's a regression, TS version doesn't have |
Resolved. |
Great work, thanks @LitoMore! |
Resolve #2
Difference from #4
--typescript
option for creating with TypeScript Reacttemplates/_common
directory@sindresorhus/tsconfig
source
directory name for source code