Start removing allFutures #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinkingsugar
commented
Mar 29, 2020
|
btw @cheatfate would be nice if we mark deprecate |
arnetheduck
reviewed
Mar 31, 2020
|
For now blocked by status-im/nim-chronos#87 |
sinkingsugar
commented
Apr 2, 2020
sinkingsugar
commented
Apr 2, 2020
sinkingsugar
commented
Apr 2, 2020
sinkingsugar
commented
Apr 2, 2020
sinkingsugar
commented
Apr 2, 2020
arnetheduck
reviewed
Apr 6, 2020
arnetheduck
reviewed
Apr 6, 2020
dryajov
reviewed
Apr 9, 2020
libp2p/muxers/mplex/lpchannel.nim
Outdated
| s.cleanUp() | ||
| ) | ||
|
|
||
| for res in futs: |
There was a problem hiding this comment.
this seems pretty repetitive, can we perhaps move this to a template, are they sufficiently similar to be able to generalize?
dryajov
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
LGTM, but a few comments.
- First, the error handling code is repetitive and can probably be generalized into a couple of templates, specially in
LPChannel. - Second, all the error checking code does is fail/report the first exception. This seems like the most common pattern and an indication that this should be moved into
allFinishedor anotherallXXXprimitive, that will simply do the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just by removing a few in
lpchanneland useawaitneI finally realized how the program flow worked and specially each test termination... (check any CI to see yourself!)