Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fda vaccine update pull request #735

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Fda vaccine update pull request #735

merged 8 commits into from
Aug 21, 2024

Conversation

xingxianli
Copy link
Contributor

No description provided.

@xingxianli xingxianli requested a review from zhengj2007 August 16, 2024 18:59
Copy link
Contributor

@zhengj2007 zhengj2007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. rename vaccine_FDA.csv to vo_FDA.csv
  2. no need to add new term 'GlaxoSmithKline Biologicals' and 'GlaxoSmithKline Biologicals SA', we can use VO:0000690 'GlaxoSmithKline plc'. Add 'GSK' as alternative term of VO:0000690 'GlaxoSmithKline plc'
  3. 'vaccine monovalent role' and 'vaccine multivalent role' are subClassOf 'vaccine role'. Definitions are also need to be improved.
    'vaccine monovalent role' is 'A vaccine that is designed to immunize against a single antigen or single strain of a pathogen.'
    'vaccine multivalent' is 'A vaccine that is designed to immunize against multiple antigen or multiple strain of a pathogen.'

@xingxianli xingxianli requested a review from zhengj2007 August 21, 2024 16:56
@zhengj2007 zhengj2007 merged commit b4d5e2b into master Aug 21, 2024
@zhengj2007 zhengj2007 deleted the FDA branch August 21, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants