chore(v038): coderabbit fixes on droplet driver, watcher, bench fence#148
Conversation
Three CodeRabbit findings on PR #147 addressed against main: - scripts/v038_droplet_run.sh: docker run -d sent runtime logs to the detached client process so the redirect captured only the container ID. Split the docker run from a background docker logs -f writing to vllm_llama33.log, so the health-check tail path and the watcher rsync both see real vLLM server output. - scripts/v038_local_watcher.sh: SSH probes inside the watch loop ran without ConnectTimeout or ServerAliveInterval, which would freeze progress detection on a stalled connection. Lifted SSH_OPTS into a module-scope array (BatchMode, ConnectTimeout=10, ServerAliveInterval=15, ServerAliveCountMax=2) and rewired the three ssh calls through it. - bench/vaara-bench-v0.38.md: bare fence on the reproduction recipe block tagged as bash for markdownlint MD040 and reader syntax highlighting. The shipped v0.38 generation run already completed cleanly so these do not affect the release artifacts. The fixes propagate into the canonical scripts so the v0.39 generation harness picks up the corrected shape.
|
Warning Review limit reached
More reviews will be available in 23 minutes. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Three CodeRabbit findings from PR #147 (post-merge) addressed against main. See commit message for the per-file rationale.