Skip to content

docs(mcp-proxy): real upstream invocations, promote to top-level README section#105

Merged
vaaraio merged 2 commits into
mainfrom
docs/mcp-proxy-fix-real-invocations
May 19, 2026
Merged

docs(mcp-proxy): real upstream invocations, promote to top-level README section#105
vaaraio merged 2 commits into
mainfrom
docs/mcp-proxy-fix-real-invocations

Conversation

@vaaraio
Copy link
Copy Markdown
Owner

@vaaraio vaaraio commented May 19, 2026

Summary

Two problems shipped in #100 and #101, both fixed here:

  1. README's MCP proxy code example referenced a fictional npm package (@sap/adt-mcp-server). It also buried the MCP proxy block as a third-tier subsection under Framework integrations, despite v0.21.0 being the headline ship and having two worked demos.
  2. SAP demo's example config used a broken npx invocation (npx -y @mario-andreschak/mcp-abap-abap-adt-api — that package isn't published on npm under that scope). Real install path is clone + build + run with node /path/to/dist/index.js.

Changes

README.md

  • Removed the buried ### MCP proxy block from under Framework integrations.
  • Added a new top-level ## MCP proxy section between TypeScript client and OVERT.
  • One-line worked example uses @sap/mdk-mcp-server, SAP's official Mobile Development Kit MCP server (published on npm, version 0.3.7, Apache-2.0, verified).
  • Cross-links to both demo folders.

examples/sap-mcp-proxy-demo/claude_code_config.example.json

  • Primary block (sap-mdk-via-vaara) now uses the real @sap/mdk-mcp-server npx invocation with --schema-version 26.3.
  • Sibling _alternative_abap_adt block uses the real node /PATH_TO_YOUR/mcp-abap-abap-adt-api/dist/index.js invocation per Mario's README.
  • Sibling _alternative_btp_odata block clarified as the same clone+build shape for lemaiwo's server.

examples/sap-mcp-proxy-demo/README.md

  • Prereqs section now names each upstream's actual install path (npm-published for MDK, clone+build for the others).
  • Before/After config blocks now show the real MDK invocation.
  • Body text now steers ABAP/OData readers to the alternative blocks in the example config.

Verification

All upstream package/repo references verified live this session:

  • @sap/mdk-mcp-server on npm: version 0.3.7, bin mdk-mcp, description "Model Context Protocol (MCP) server for AI-assisted development of MDK applications" — runnable via npx -y @sap/mdk-mcp-server.
  • SAP/mdk-mcp-server repo: 31 stars, Apache-2.0.
  • mario-andreschak/mcp-abap-abap-adt-api repo: 134 stars, MIT, install path confirmed from its README is node /path/to/dist/index.js after clone + npm install + npm run build.
  • @mario-andreschak/mcp-abap-abap-adt-api on npm: not found (was the broken reference).

Docs-only. No code changes, no test changes.

…ME section

Two problems shipped in #100 and #101 that were fixed here:

1. README's MCP proxy code example used `npx --upstream-arg @sap/adt-mcp-server`, a fictional npm package. The MCP proxy block was also buried as a third-tier subsection under Framework integrations, despite v0.21.0 being the headline ship and having two worked demos.

2. SAP demo's example config used `npx -y @mario-andreschak/mcp-abap-abap-adt-api`, which is not published on npm. The real install path for that server is git clone + npm install + npm run build, then run with `node /path/to/dist/index.js`.

Fixes:

- README: removed the buried `### MCP proxy` subsection under Framework integrations and added a top-level `## MCP proxy` section between TypeScript client and OVERT. Uses `@sap/mdk-mcp-server` (verified on npm at version 0.3.7) as the one-line example. Links both demo folders.

- examples/sap-mcp-proxy-demo/claude_code_config.example.json: primary `sap-mdk-via-vaara` block now uses the real `@sap/mdk-mcp-server` invocation. Sibling `_alternative_abap_adt` block uses the real `node /PATH_TO_YOUR/mcp-abap-abap-adt-api/dist/index.js` invocation. Sibling `_alternative_btp_odata` block clarified as clone+build.

- examples/sap-mcp-proxy-demo/README.md: prereqs section names each upstream's real install path. Before/After config blocks now show the real MDK invocation. Note steering ABAP/OData readers to the alternative blocks in the example config.

Verified upstreams via npm registry and GitHub API: `@sap/mdk-mcp-server` is published, official, Apache-2.0; `mario-andreschak/mcp-abap-abap-adt-api` is on GitHub (134 stars, MIT) but not on npm; `SAP/mdk-mcp-server` repo is Apache-2.0, 31 stars.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Warning

Rate limit exceeded

@vaaraio has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 52c6bbf4-5a5c-4a4c-b5a6-73eb9f139ab0

📥 Commits

Reviewing files that changed from the base of the PR and between 724a676 and 9a3c401.

📒 Files selected for processing (3)
  • README.md
  • examples/sap-mcp-proxy-demo/README.md
  • examples/sap-mcp-proxy-demo/claude_code_config.example.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/mcp-proxy-fix-real-invocations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vaaraio vaaraio merged commit 4aa7668 into main May 19, 2026
10 checks passed
@vaaraio vaaraio deleted the docs/mcp-proxy-fix-real-invocations branch May 19, 2026 18:00
vaaraio added a commit that referenced this pull request May 19, 2026
…mple version, cross-reference MCP server vs MCP proxy (#106)

Three small cleanups noticed in the README sweep after PR #105:

1. Em-dashes in seven bullet items (Framework integrations and Cloud guardrails) replaced with the period-after-bold style used in the new MCP proxy section.

2. OVERT 1.0 code example bumped from `arbiter_version="vaara/0.15.0"` to `"vaara/0.21.0"` to match the current shipped release.

3. The Framework integrations MCP server bullet now cross-references the top-level MCP proxy section, so a scanner reading the integrations list immediately sees that vaara.integrations.mcp_server (Vaara as MCP server) is distinct from the MCP proxy (Vaara in front of an upstream MCP server).

Co-authored-by: vaaraio <267591518+vaaraio@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant