Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: another attempt to stabilize grid-pro test #8585

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jan 29, 2025

image

There was sometimes a second focus call originating from:

_onAnimationEnd(e) {
// ShadyCSS applies scoping suffixes to animation names
if (e.animationName.indexOf('vaadin-grid-appear') === 0) {
e.stopPropagation();
// Ensure header and footer have tabbable elements
this._resetKeyboardNavigation();
requestAnimationFrame(() => {
this.__scrollToPendingIndexes();
});
}
}

The PR updates the tests to wait for this animation to finish before any interactions.

@vursen vursen force-pushed the attempt-to-fix-grid-pro-test branch from 2c8f669 to cb799f1 Compare January 29, 2025 07:39
@vursen vursen marked this pull request as ready for review January 29, 2025 07:42
@vursen vursen requested a review from web-padawan January 29, 2025 07:42
@web-padawan web-padawan merged commit 63e087a into main Jan 29, 2025
9 checks passed
@web-padawan web-padawan deleted the attempt-to-fix-grid-pro-test branch January 29, 2025 08:34
vursen added a commit that referenced this pull request Jan 29, 2025
vursen added a commit that referenced this pull request Jan 29, 2025
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.alpha7 and is also targeting the upcoming stable 24.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants