Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade SauceLabs launcher to the latest version #8573

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Jan 28, 2025

Description

My PR to @web/test-runner-saucelabs was merged and released: modernweb-dev/web#2852

  • Upgraded the dev dependency version in package.json, let's see if visual tests pass.
  • Updated filterBrowserLogs to filter out webdriver debug warnings from their customElements wrapper

Type of change

  • Internal change

Note

There are some webdriver errors when running tests for more than a single file.
Added a comment about that here webdriverio/webdriverio#13467 (comment)

UPD: reported a new issue for this error webdriverio/webdriverio#14129

@web-padawan web-padawan requested a review from vursen January 28, 2025 09:13
@web-padawan web-padawan force-pushed the chore/bump-sauce-launcher branch from 4d38c5f to 0df4863 Compare January 28, 2025 10:28
@web-padawan
Copy link
Member Author

There are some problems with custom "set-window-height" command, I'll look into switching to setViewport().

 ❌ Error: Error while executing command set-window-height with payload {"height":610}: WebDriverError: unknown error: failed to change window state to 'normal', current state is 'maximized'

@web-padawan
Copy link
Member Author

Created #8577 to fix the CSS override for vaadin-multi-select-combo-box to properly hide caret in focused chip test.

@web-padawan web-padawan force-pushed the chore/bump-sauce-launcher branch 3 times, most recently from b860f87 to e675786 Compare January 29, 2025 09:07
package.json Outdated Show resolved Hide resolved
@web-padawan web-padawan force-pushed the chore/bump-sauce-launcher branch from e675786 to 2231624 Compare February 3, 2025 08:23
Copy link

sonarqubecloud bot commented Feb 3, 2025

@web-padawan web-padawan changed the title chore: upgrade SauceLabs launcher to the version based on Webdriver 9 chore: upgrade SauceLabs launcher to the latest version Feb 3, 2025
@sissbruecker
Copy link
Contributor

@web-padawan We'll need the SauceLabs version bump also in version branches in order to run visual tests from there.

@web-padawan
Copy link
Member Author

Right, added labels to cherry-pick this PR. I think we can ignore webdriver errors in the logs for now since the tests pass.

@web-padawan web-padawan removed the request for review from vursen February 3, 2025 09:16
@web-padawan web-padawan merged commit bc65e61 into main Feb 3, 2025
9 checks passed
@web-padawan web-padawan deleted the chore/bump-sauce-launcher branch February 3, 2025 09:16
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick bc65e61
error: could not apply bc65e61... chore: upgrade SauceLabs launcher to the latest version (#8573)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 23.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick bc65e61
error: could not apply bc65e61... chore: upgrade SauceLabs launcher to the latest version (#8573)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.alpha7 and is also targeting the upcoming stable 24.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants