Skip to content

Conversation

@ugur-vaadin
Copy link
Contributor

@ugur-vaadin ugur-vaadin commented Oct 30, 2025

Description

This PR is a prototype for implementing the following for the RichTextEditor:

  • basic validation including error message, required state as a constraint, and the required indicator
  • label and helper text
  • accessibility support for the features

Some notes:

  • it should also support further constraints like minLength, maxLength etc as constraints
  • lacks visual tests
  • added styles break the borders in Lumo
  • the baseline images seem to be 2 pixels shorter

Prototype for the improvements in https://github.com/vaadin/components-team-tasks/issues/631

Type of change

  • Bugfix
  • Feature
  • Prototype

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/pr
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants