fix: change checked condition on button removal #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior this change, the conditional checks whether the button being removed is checked or not, in order of resetting the group value. That works well, unless a new button is checked right after the checked button is removed. Since the resetting logic is done inside a FlattenedNodesObserver, it happens asynchronously and the selected button being removed is no longer the actual value of the group, therefore no reset is needed. Fix vaadin/vaadin-radio-group-flow#108
DiegoCardoso
force-pushed
the
fix/removing-and-setting-value
branch
from
019e719 to
2202ac2
Compare
tomivirkki
approved these changes
Sep 9, 2020
DiegoCardoso
added a commit
that referenced
this pull request
Sep 9, 2020
DiegoCardoso
added a commit
that referenced
this pull request
Sep 9, 2020
DiegoCardoso
added a commit
that referenced
this pull request
Sep 9, 2020
DiegoCardoso
added a commit
that referenced
this pull request
Sep 9, 2020
DiegoCardoso
added a commit
that referenced
this pull request
Sep 9, 2020
DiegoCardoso
added a commit
that referenced
this pull request
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior this change, the conditional checks whether the button being removed is checked or not, in order of resetting the group value.
That works well, unless a new button is checked right after the checked button is removed. Since the resetting logic is done inside a FlattenedNodesObserver, it happens asynchronously and the selected button being removed is no longer the actual value of the group, therefore no reset is needed.
Fix vaadin/vaadin-radio-button-flow#108