-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement focus-trap #15
Conversation
c1f150e
to
e96fc76
Compare
Tests are finally working in all browsers, ready for review 🚀 |
Seems to be working well 👍 Review status: 0 of 5 files reviewed at latest revision, 2 unresolved discussions. vaadin-overlay.html, line 302 at r2 (raw file):
Prefer vaadin-overlay.html, line 304 at r2 (raw file):
The set is different from https://github.com/vaadin/vaadin-grid/blob/master/vaadin-grid-cell-click-behavior.html#L63 Probably both sets have some flaws Comments from Reviewable |
e96fc76
to
cb0f8aa
Compare
cb0f8aa
to
d757b54
Compare
Review status: 0 of 5 files reviewed at latest revision, 2 unresolved discussions. vaadin-overlay.html, line 302 at r2 (raw file): Previously, tomivirkki (Tomi Virkki) wrote…
Done, thx! vaadin-overlay.html, line 304 at r2 (raw file): Previously, tomivirkki (Tomi Virkki) wrote…
Good point, it's good to be aligned in such cases. I copied the set from Grid with a small additional check for Comments from Reviewable |
Reviewed 2 of 5 files at r2, 3 of 3 files at r3. Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
In #13 we decided to move focus-trap functionality (which will be required by
vaadin-dialog
) tovaadin-overlay
.This change is