Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't dispatch click event for disabled element #49

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

samiheikki
Copy link
Contributor

@samiheikki samiheikki commented Dec 17, 2018

Fixes vaadin/vaadin-button#116


This change is Reviewable

@web-padawan
Copy link
Member

Note: Polymer supports this behaviour for whitelist of native form controls only, this has been introduced in Polymer/polymer#5230

So, in our case we need this overriding to make it work with the elements extending ControlStateMixin as they are expected to behave similarly to native form controls.

@web-padawan web-padawan merged commit d3fd5ed into master Dec 27, 2018
@web-padawan web-padawan deleted the fix/click-disabled-element branch December 27, 2018 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants