fix: disable validation of internal text-field #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
force-pushed
the
fix/disable-validation-of-internal-text-field
branch
from
947404f
to
7b2ef0b
Compare
|
The tests failed in iOS Simulator due to a timeout. I think it's not a big deal since they passed in all the other environments. |
web-padawan
approved these changes
Sep 21, 2023
vursen
added a commit
that referenced
this pull request
Sep 21, 2023
1 task
vursen
added a commit
that referenced
this pull request
Sep 21, 2023
web-padawan
pushed a commit
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR disables the internal text-field's validation so that it doesn't override the propagated invalid state.
Fixes vaadin/flow-components#5409
Type of change